tremor-runtime icon indicating copy to clipboard operation
tremor-runtime copied to clipboard

Shrink large functions

Open Licenser opened this issue 5 years ago • 2 comments

We have a number of functions that are marked as clippy::too_many_lines - it would be good to go over them and see if they can be cut down into easier to understand functions.

Licenser avatar Dec 12 '19 14:12 Licenser

Nothing is found with clippy. Everything is refactored?

0xdeafbeef avatar May 01 '20 20:05 0xdeafbeef

@0xd34b33f there's quite a few of them still: https://github.com/wayfair-tremor/tremor-runtime/search?q=too_many_lines&unscoped_q=too_many_lines

We have clippy exceptions for them right now so they don't show up with clippy.

If you are interested in refactoring them, feel free to take this!

anupdhml avatar May 06 '20 13:05 anupdhml