Tomas Remes

Results 21 comments of Tomas Remes

I haven't tested it, but I have already reviewed it couple of times. /lgtm

@JoelSpeed No. It's 4.18 so I can wait for the branching.

@JoelSpeed would you please find some time for this one?

@JoelSpeed OK let me try to add some tests.

I've added few tests for this one and updated the regex a little bit. Please check @JoelSpeed, Thank you

@JoelSpeed it's not. Fixed. Thanks @everettraven

Hi, I came across this issue. Does this include also time formatting (in a table) in general please? I would like to have something like:

Thanks for super quick response @AntoineThebaud. > ... assuming you want to render a timestamp as a human-readable date. yes please :)

@thibaultmg do you mean to move the dashboard definition to `platform-mcoa` folder and the metrics then need to be in the [scrape-config.yaml](https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/manifests/base/grafana/platform-mcoa/scrape-config.yaml) ?