HTML-Table-to-JSON icon indicating copy to clipboard operation
HTML-Table-to-JSON copied to clipboard

Published 20 hours ago • verified publisher icon tremblay

Some initial refactor suggestions

Open ivansabik opened this issue 10 years ago • 4 comments

hey colin, i'm testing out your code and if it works as expected it's a very useful tool for me since I do lots of web scraping. I'm working right now with a 25 MB HTML response that has around 40 colums. May I suggest the following?:

  • Make the package avaiable on Packagist to be able to install with Composer (kind of easy)
  • Use PHP Unit for tests (you already have the tests defined so it should also be relatively straightforward)

I made a fork from your code so when I get some free time I'll work on it

ivansabik avatar Aug 28 '14 22:08 ivansabik

Ivan, I appreciate the suggestions and look forward to seeing the Pull request! This project is definitely on the back burner for me right now, but I'll be sure to review your PR when it comes.

tremblay avatar Aug 29 '14 00:08 tremblay

Hi guys! I found the project just now. I see that is not developing anymore. What do you use instead?

bystro avatar Feb 27 '19 10:02 bystro

Hi! I have developed and published package on packagist https://packagist.org/packages/bystro/html-table-converter

bystro avatar Mar 05 '19 12:03 bystro

Hi! I have developed and published package on packagist https://packagist.org/packages/bystro/html-table-converter

Hi! Is your package able to deal with empty cells? I can't seem to find a way to properly handle this issue, since it's affecting the length of some of the table columns when an empty cell is found.

aosorio9559 avatar Oct 29 '20 00:10 aosorio9559