SMESH icon indicating copy to clipboard operation
SMESH copied to clipboard

Create create_release.yml

Open looooo opened this issue 4 years ago • 7 comments

just copying some snippets.

looooo avatar Feb 21 '21 22:02 looooo

@trelau any ideas how to test the gh-action instructions?

looooo avatar Feb 22 '21 19:02 looooo

@looooo no. what's the intent of this file/PR?

trelau avatar Feb 23 '21 01:02 trelau

To create a release with the final sources. So we can build smesh from a zipped file.

looooo avatar Feb 23 '21 02:02 looooo

To create a release with the final sources. So we can build smesh from a zipped file.

A few thoughts/questions:

  • Do the final sources need to be prepared only for a release? Or should they be packaged up as an artifact for every Github Action?
  • I "think" it's possible to use CMake to manage submodules and fetch external content. If retrieving the external git repos and checking out the right tag for each submodule was managed by CMake, and therefore part of the build process, would that work instead? Essentially making what's done in prepare.py part of CMake in addition to first downloading the external content.

I could imagine a few approaches:

  • Modify the Github Action workflow to store as an artifact the sources (essentially the src folder after the prepare.py script is run, along with all the other supporting files of course)
  • These artifacts could probably be triggered only for release builds, and I assume we could figure out how to automatically attach the artifacts to the release in Github. Otherwise, at least to start, attaching these artifacts to the release can be done manually.

trelau avatar Feb 23 '21 10:02 trelau

@looooo maybe let's carry on the convo here https://github.com/trelau/SMESH/issues/38? Then we can circle back on this PR convo when we have a path forward?

trelau avatar Feb 23 '21 10:02 trelau

@trelau this works now on my fork. But I am not sure if uploading works as expected. Currently the upload uses the branch name, see here: https://github.com/looooo/SMESH/releases/tag/create_release

i guess this should only be done for tags / releases.

looooo avatar Nov 04 '21 16:11 looooo

This would be quite useful, right now the smesh-feedstock relies on cloning the repo which is a very ugly solution.

basnijholt avatar Dec 09 '21 21:12 basnijholt