trefle-api icon indicating copy to clipboard operation
trefle-api copied to clipboard

USDA Leaf Retention mapping states "null" rather than "false" or "no"

Open charitygrace opened this issue 5 years ago • 1 comments

Describe the bug The USDA Leaf Retention field maps correctly when the USDA reports a "Yes" value. Trefle states "true". However, when the USDA reports a "No" value, Trefle does not report a value and simply states "null". "null" and "false" are not the same thing.

To Reproduce To see "Yes" correctly mapped to "true": https://plants.sc.egov.usda.gov/java/charProfile?symbol=ABFR https://trefle.io/api/species/101129

To see "No" incorrectly mapped to "null": https://plants.sc.egov.usda.gov/java/charProfile?symbol=ACSA3 https://trefle.io/api/species/101870

charitygrace avatar Jun 10 '20 17:06 charitygrace

Indeed ! Thanks for the report !

lambda2 avatar Jun 11 '20 03:06 lambda2