lakeFS icon indicating copy to clipboard operation
lakeFS copied to clipboard

Fix broken link to pyspark.sql.DataFrame.printSchema

Open yonipeleg33 opened this issue 1 year ago • 3 comments

Closes #8110

yonipeleg33 avatar Aug 28 '24 10:08 yonipeleg33

:recycle: PR Preview e07df5ee2a7d5f9fde0278757a4b6e55698624eb has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

github-actions[bot] avatar Aug 28 '24 10:08 github-actions[bot]

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

github-actions[bot] avatar Aug 28 '24 10:08 github-actions[bot]

E2E Test Results - Quickstart

10 passed

github-actions[bot] avatar Aug 28 '24 10:08 github-actions[bot]

Cool!

Not approving and instead adding @kesarwam and/or @talSofer because it's their page and we're bumping the PySpark version. Do we want to push it so far ahead?

What's the reasoning for the version update? is it broken on the earlier version? @yonipeleg33 was this tested?

talSofer avatar Aug 29 '24 09:08 talSofer

Cool! Not approving and instead adding @kesarwam and/or @talSofer because it's their page and we're bumping the PySpark version. Do we want to push it so far ahead?

What's the reasoning for the version update? is it broken on the earlier version? @yonipeleg33 was this tested?

@talSofer This link simply does not exist in this version. If you'll go to the new link, you'll see their documentation's oldest version is 3.3.0, which is already two majors above the old, broken API.

Versions dropdown screenshot

image

So I don't see much value in bumping up 2 majors and not moving to the current latest...

was this tested?

WDYM by tested? I just looked for an actual link in their documentation pointing to the desired API, haven't tried running it or something

yonipeleg33 avatar Aug 29 '24 10:08 yonipeleg33

Merging this since CI is failing. @talSofer feel free to open a different issue for anything that needs to be tested

itaiad200 avatar Sep 02 '24 11:09 itaiad200

@yonipeleg33 documentation PRs do not require include-changelog label

N-o-Z avatar Sep 05 '24 13:09 N-o-Z