lakeFS icon indicating copy to clipboard operation
lakeFS copied to clipboard

Bump @75lb/deep-merge from 1.1.1 to 1.1.2 in /webui

Open dependabot[bot] opened this issue 1 year ago • 2 comments

Bumps @75lb/deep-merge from 1.1.1 to 1.1.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Aug 07 '24 15:08 dependabot[bot]

E2E Test Results - Quickstart

10 passed

github-actions[bot] avatar Aug 07 '24 15:08 github-actions[bot]

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

github-actions[bot] avatar Aug 07 '24 15:08 github-actions[bot]

[updating here] This is definitely low risk. Any one of these two reasons alone would be enough to make it unusable:

  1. The attack is via prototype pollution into lodash merge methods. webui only ever uses lodash.noop directly. So any prototype pollution will not affect the data path on the GUI
  2. The only package in our package-lock actually using deep-merge is table-layout, and the path upwards to an app call is via jsdom, then either vitest or mathjax. vitest is unused, we don't run a vite test even in dev. mathjax appears via ipynb notebooks support. So the only way to pollute a prototype might be through a notebook stored in lakeFS - i.e. an by an authenticated user on a system whose server is specifically designed to keep an audit trail of all actions.

Definitely fix, but surely not in haste.

arielshaqed avatar Sep 19 '24 09:09 arielshaqed

@dependabot rebase

arielshaqed avatar Sep 30 '24 05:09 arielshaqed

Oh no, it's the awful license/cla-is-stuck. Since pushing an empty commit will require another full Esti run, I'll just force-pull this one.

arielshaqed avatar Sep 30 '24 06:09 arielshaqed