lakeFS
lakeFS copied to clipboard
[Bug]: UI not using pre-sign when showing Uncommitted object changes
trafficstars
What happened?
When using lakeFS in Minimal Permissions in S3 In Uncommitted Changes > "Show object changes" > Error: S3 Access Denied.
Users are not able to see object changes in the UI. If users configured presigned mode via disable_pre_signed_ui they are expecting the UI to use presign URLs but it does not and instead uses lakeFS getObject regular API. If using minimal IAM permissions: Users are not able to see object changes in the UI and will get an error.
Steps to Reproduce:
- Configure lakeFS server to use presign URL in AWS disable_pre_signed_ui.
- Do some file action (i.e delete object) and don't commit.
- Go to UI > Uncommitted changes > "Show object changes" > Inspect network tab: the UI does not specify
presign=truewhen callinggetObject.
Expected behavior
The UI should use presign=true to fetch the object and show the changes.
Root Cause
The UI should pass presign=true when calling getObject in Diff here and here