lakeFS icon indicating copy to clipboard operation
lakeFS copied to clipboard

ariels' version of: Upgrade version of `oapi-codegen`

Open arielshaqed opened this issue 11 months ago • 7 comments

ariels' version of #7493. This one is more for working and linking than it is for pulling!

arielshaqed avatar Mar 06 '24 14:03 arielshaqed

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

github-actions[bot] avatar Mar 06 '24 14:03 github-actions[bot]

Looks like the current failures are due to kin-openapi changes in between the versions we're using - I can see pkg/api/tmpl/inline.tmpl may need an update, but once updating it it doesn't regenerate any of the templates we've got

jamietanna avatar Mar 06 '24 20:03 jamietanna

Looks like the current failures are due to kin-openapi changes in between the versions we're using - I can see pkg/api/tmpl/inline.tmpl may need an update, but once updating it it doesn't regenerate any of the templates we've got

Yeah, I figured those out. Now it's broken because the new codegen the OpenAPI 3.1 interpretation that forbids DELETE with a body. Can I override that setting somehow?

arielshaqed avatar Mar 07 '24 14:03 arielshaqed

@arielshaqed the reason for the failures was due to the incorrect placement of the template files. It changed a lot since the old 1.5.6 days...

Mind the change under the: pkg/api/apigen/tmpl path

Jonathan-Rosenberg avatar Mar 21 '24 11:03 Jonathan-Rosenberg

🎊 PR Preview 9ebd11895d90dae79f1776f56b245603275a3c62 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-7532.surge.sh

:clock1: Build time: 0.012s

🤖 By surge-preview

github-actions[bot] avatar Apr 10 '24 11:04 github-actions[bot]

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

github-actions[bot] avatar Apr 10 '24 11:04 github-actions[bot]

This PR is now marked as stale after 30 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

github-actions[bot] avatar May 12 '24 01:05 github-actions[bot]