lakeFS icon indicating copy to clipboard operation
lakeFS copied to clipboard

Published 20 hours ago • verified publisher icon treeverse

Parallel commits compare

Open itaiad200 opened this issue 2 years ago • 1 comments

Another try

itaiad200 avatar Sep 21 '22 12:09 itaiad200

Thanks Itai! I have read through this, and though I don't have any substantial comments - it seems like the ListCommits function became very long, and at points very complicated to understand. I think that if there's a way to break this into smaller logical units it would be much easier to read

I agree. Improved it some more. Breaking it for path / non-paths log-commits usage should make the code clearer at least for the common flow (non-paths). LMKWYT

itaiad200 avatar Oct 04 '22 08:10 itaiad200

Tested it locally by adding 200ms delay to block adapter read and zeroing out the cache. For 200 commits we currently log all of them in 78 seconds. This change reduces that number to 6 seconds.

itaiad200 avatar Oct 04 '22 08:10 itaiad200

Tested locally again after all changes applied, the above numbers are still valid. Thanks all for the improvements and the review! Pulling..

itaiad200 avatar Oct 19 '22 07:10 itaiad200