lakeFS icon indicating copy to clipboard operation
lakeFS copied to clipboard

Published 20 hours ago • verified publisher icon treeverse

Change Esti S3 endpoint client to use path style format

Open idanovo opened this issue 2 years ago • 1 comments

idanovo avatar Sep 21 '22 08:09 idanovo

@arielshaqed @itaiad200 You are absolutely right. Added also tests for the host base convention

idanovo avatar Sep 21 '22 12:09 idanovo

From the PR it looks like delete and multipart are using the the s3 client to test the gateway. I think we can get from viper 'S3ForcePathStyle' value and run the same tests for all environments.

@nopcoder but we want to test it once with a host-base client and once using a path-base client, don't we?

idanovo avatar Sep 22 '22 11:09 idanovo

@nopcoder but we want to test it once with a host-base client and once using a path-base client, don't we?

True, when you pull the value from viper you can run the system tests when it is 'off' and other tests when it is 'on'.

nopcoder avatar Sep 22 '22 11:09 nopcoder