lakeFS
lakeFS copied to clipboard
SigV4 returns wrong error for mismatched date and signed-date
When the date in the signed credentials on a SigV4 request does not match the date (or x-amz-date) on the message we return ErrMalformedCredentialDate (see function getAmzDate).
In fact we should return an explanatory SignatureDoesNotMatch. See https://docs.aws.amazon.com/general/latest/gr/signature-v4-troubleshooting.html, starting with text:
The date that you use as part of the credential must match the date value in the
x-amz-dateheader.
This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.
Still an error, and users will have a harder time debugging some integrations.