lakeFS icon indicating copy to clipboard operation
lakeFS copied to clipboard

SigV4 returns wrong error for mismatched date and signed-date

Open arielshaqed opened this issue 4 years ago • 2 comments

When the date in the signed credentials on a SigV4 request does not match the date (or x-amz-date) on the message we return ErrMalformedCredentialDate (see function getAmzDate).

In fact we should return an explanatory SignatureDoesNotMatch. See https://docs.aws.amazon.com/general/latest/gr/signature-v4-troubleshooting.html, starting with text:

The date that you use as part of the credential must match the date value in the x-amz-date header.

arielshaqed avatar Sep 13 '21 11:09 arielshaqed

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

github-actions[bot] avatar Nov 01 '23 14:11 github-actions[bot]

Still an error, and users will have a harder time debugging some integrations.

arielshaqed avatar Nov 10 '23 06:11 arielshaqed