David Feuer

Results 792 comments of David Feuer

Yeah, I think you're biased. I imagine just as many people will need the others.

I wonder if we can generalize this idea some more, taking some inspiration from `mergeA`. Suppose we have two predicates, `p, q :: k -> Bool`, with the following properties:...

Yes, this has been noted before, and is weird. But people are probably relying on the current behavior, so we shouldn't change it. Would you like to open a PR...

I don't think it would be bad to have such a package, but I have very little sense of what would go in it. Some things above are now in...

I don't think we want to draw such fine distinctions. Internal structural equality is really Not Interesting, and we never make any promises about it.

> For examples, I think we should adopt the `doctest` style that is also increasingly being used in [`base`](https://gitlab.haskell.org/ghc/ghc/-/issues/17929) and other libraries. In this style, the example should look like...

And no, I do not want to put a quintillion `fromList`s in there. `map` is fine.

I don't like `==` because these things don't necessarily have `Eq` instances, and because `==` is a `Bool`-valued Haskell function rather than a logical predicate. Properties are not Haskell code.

Agreed; this commit can't be blamed for subtle inlining interactions, unless it does something wrong with inlining.

I know nothing about test frameworks, so I'm very happy to let other people decide. On Thu, Aug 5, 2021 at 11:45 AM Simon Jakobi ***@***.***> wrote: > @treeowl How...