astro-sanity icon indicating copy to clipboard operation
astro-sanity copied to clipboard

Fixing TypeScript Declaration Issue in 'astro-sanity' Package

Open ps-kate opened this issue 1 year ago • 3 comments

Hey there! 👋

I ran into an issue with the 'astro-sanity' package (version 1.1.7) while working on my project. It seems there's a problem with TypeScript type declarations that results in a errors and warnings:

src/pages/posts/index.astro:6:39 - error ts(7016): Could not find a declaration file for module 'astro-sanity'. '/Users/***/Sites/***/node_modules/astro-sanity/dist/astro-sanity.mjs' implicitly has an 'any' type.
  There are types at '/Users/***/Sites/***/node_modules/astro-sanity/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'astro-sanity' library may need to update its package.json or typings.

Here's the fix that worked for me:

diff --git a/node_modules/astro-sanity/package.json b/node_modules/astro-sanity/package.json
index 2b4b11a..5fc451e 100644
--- a/node_modules/astro-sanity/package.json
+++ b/node_modules/astro-sanity/package.json
@@ -10,7 +10,8 @@
   "exports": {
     ".": {
       "import": "./dist/astro-sanity.mjs",
-      "require": "./dist/astro-sanity.js"
+      "require": "./dist/astro-sanity.js",
+      "types": "./dist/index.d.ts"
     }
   },
   "files": [

I've created this pull request to address the issue and help others who might face the same problem. Let's get this fix merged!

Best regards, Kate

ps-kate avatar Sep 15 '23 22:09 ps-kate

Issue still exists.

brandondeweese avatar Oct 06 '23 03:10 brandondeweese

Bumping as its happening for me too

adstr123 avatar Oct 31 '23 17:10 adstr123

This is still happening for me as well.

chris-nowicki avatar Nov 09 '23 16:11 chris-nowicki