wahooMapsCreator icon indicating copy to clipboard operation
wahooMapsCreator copied to clipboard

[DEV] use `pyhgtmap` instead of `phyghtmap` for generating contour lines

Open treee111 opened this issue 2 years ago • 1 comments

This PR…

  • switches to file-versioned and published (PyPi) python module pyhgtmap
  • no manual (kind of difficult) installation of phyghtmap needed anymore
  • closes #217

Considerations and implementations

Till now, there is no support for Windows, see https://github.com/agrenott/pyhgtmap/issues/7

ToDO

adjust documentation fix version of pyhgtmap and think of other publish-related stuff for this PR

How to test

  1. create environment gdal-dev-pyh using env .yml file
  2. switch to the environment
  3. swith to this branch
  4. Run wahooMapsCreator and include contour lines using -con
  5. Check if the result is the same as using phyghtmap

Pull Request Checklist

  • [x] Reviewed the Contributing Guidelines
  • [x] Commits (and commit-messages) are understandable
  • [x] Tested with macOS / Linux
  • [ ] Tested with Windows

treee111 avatar Nov 20 '23 09:11 treee111

I think we can just use pyhgtmap with "jobs=1", then no forking is attempted, and it should work on windows as well. And then rather use asyncio to launch several instances of pyhgtmap. I'll do some testing on linux first and then on windows.

alfh avatar Dec 04 '23 17:12 alfh