wahooMapsCreator
wahooMapsCreator copied to clipboard
[DEV] use `pyhgtmap` instead of `phyghtmap` for generating contour lines
This PR…
- switches to file-versioned and published (PyPi) python module
pyhgtmap - no manual (kind of difficult) installation of
phyghtmapneeded anymore - closes #217
Considerations and implementations
Till now, there is no support for Windows, see https://github.com/agrenott/pyhgtmap/issues/7
ToDO
adjust documentation
fix version of pyhgtmap and think of other publish-related stuff for this PR
How to test
- create environment gdal-dev-pyh using env .yml file
- switch to the environment
- swith to this branch
- Run wahooMapsCreator and include contour lines using
-con - Check if the result is the same as using
phyghtmap
Pull Request Checklist
- [x] Reviewed the Contributing Guidelines
- Especially the Pull-Requests section
- [x] Commits (and commit-messages) are understandable
- [x] Tested with macOS / Linux
- [ ] Tested with Windows
I think we can just use pyhgtmap with "jobs=1", then no forking is attempted, and it should work on windows as well. And then rather use asyncio to launch several instances of pyhgtmap. I'll do some testing on linux first and then on windows.