go icon indicating copy to clipboard operation
go copied to clipboard
verified publisher icon treeder

Some problems with go.sh ...

Open TomNussbaumer opened this issue 10 years ago • 3 comments

  1. If a user sets an own working directory with some spaces in its pathname, the script will fail in various places due to missing quotes around variables. Isn't it the first rule of shell scripting to never leave a variable unquoted? ;)
  2. "Building Docker image '$2'..." will not print the image name (wrong quotes)

TomNussbaumer avatar Sep 03 '15 15:09 TomNussbaumer

@TomNussbaumer thanks for the heads up, should wrap the $PWDs, will do that.

treeder avatar Sep 09 '15 22:09 treeder

Regarding 2, it prints the image name, are you seeing something different?

treeder avatar Sep 09 '15 22:09 treeder

Sorry for the second one. Single quotes within double quotes behave as you expect.

TomNussbaumer avatar Sep 10 '15 17:09 TomNussbaumer