tree-sitter icon indicating copy to clipboard operation
tree-sitter copied to clipboard

Use native TLS for ureq when fetching wasi-sdk

Open amaanq opened this issue 7 months ago • 3 comments

Closes #4295

Problem

ureq uses rustls by default - some consumers would prefer if it used the OS-native TLS libraries (e.g. OpenSSL)

Solution

In the ureq dependency, I've enabled the native-tls feature, and configure it to use native TLS as the TLS provider.

amaanq avatar Apr 28 '25 07:04 amaanq

Ppc64 might be screwed since Ubuntu doesn't ship BE packages.. :facepalm:

amaanq avatar Apr 28 '25 08:04 amaanq

Can't you use the native ARM runners that are (now) available on GHA instead of cross-compiling?

For PowerPC, you might want to consider dropping support (tier) for this, or gate the new SDK download behind a feature flag that you disable for this architecture (and then skip the WASM tests).

clason avatar May 07 '25 18:05 clason

The thing I like about https://github.com/tree-sitter/tree-sitter/pull/4396 over this approach is that it removes the rustls dependency. It seems like with this feature flag, ureq keeps the dependency but just lets you turn it off. That said, its not a huge deal; whatever works for end users is fine.

I also wonder if we should just shell out to curl or wget, and fail at runtime if those are not present. That way, we avoid the dynamic library dependency. What are your thoughts @amaanq

maxbrunsfeld avatar May 08 '25 04:05 maxbrunsfeld