tree-sitter-json icon indicating copy to clipboard operation
tree-sitter-json copied to clipboard

Published 20 hours ago • verified publisher icon tree-sitter

Allow only string keys

Open atmo opened this issue 7 years ago • 1 comments
trafficstars

As per JSON format specification, only strings must be allowed as keys in JSON objects.

atmo avatar Sep 08 '18 13:09 atmo

Thanks for contributing 🙇

It seems that only strings are allowed as keys in JSON objects 👍. Nice that you added a test as well! However I don't think we need to add a test when simplifying the grammar. We should be removing the test that checks that number is valid as a key in JSON objects but it seems like there isn't any test for this behavior in the parser.

Can you resolve the conflict by regenerating the parser and revert the test so we can get this merged? 🙇

Ben3eeE avatar Nov 30 '18 18:11 Ben3eeE