tree-sitter
unused parameter warnings
Hey! I pulled 1eee0d3 into a project to add JavaScript support and I'm getting these errors from cargo:
warning: vendor/tree-sitter-javascript/src/scanner.c:10:60: warning: unused parameter 'p' [-Wunused-parameter]
warning: void tree_sitter_javascript_external_scanner_destroy(void *p) {}
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:11:58: warning: unused parameter 'p' [-Wunused-parameter]
warning: void tree_sitter_javascript_external_scanner_reset(void *p) {}
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:12:66: warning: unused parameter 'p' [-Wunused-parameter]
warning: unsigned tree_sitter_javascript_external_scanner_serialize(void *p, char *buffer) { return 0; }
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:12:75: warning: unused parameter 'buffer' [-Wunused-parameter]
warning: unsigned tree_sitter_javascript_external_scanner_serialize(void *p, char *buffer) { return 0; }
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:13:64: warning: unused parameter 'p' [-Wunused-parameter]
warning: void tree_sitter_javascript_external_scanner_deserialize(void *p, const char *b, unsigned n) {}
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:13:79: warning: unused parameter 'b' [-Wunused-parameter]
warning: void tree_sitter_javascript_external_scanner_deserialize(void *p, const char *b, unsigned n) {}
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:13:91: warning: unused parameter 'n' [-Wunused-parameter]
warning: void tree_sitter_javascript_external_scanner_deserialize(void *p, const char *b, unsigned n) {}
warning: ^
warning: vendor/tree-sitter-javascript/src/scanner.c:53:57: warning: unused parameter 'payload' [-Wunused-parameter]
warning: bool tree_sitter_javascript_external_scanner_scan(void *payload, TSLexer *lexer,
warning: ^
warning: 8 warnings generated.
It's probably fine, but do y'all know about these? Are they likely to cause problems? Everything seems to work fine!
I've been getting these too whenever compiling the C code. It would be great to generate code that won't produce any warning with any popular C compiler so we don't have to fiddle with command-line flags, which is usually impractical.
I'd be happy to file, but I'm not sure if I can contextualize this correctly. Is the problem that tree-sitter is generating code which produces warnings?
Oh, sorry, yes, scanner.c is written by hand. It's parser.c that's generated. Apparently there's no great portable solution. It looks like the UNUSED() macro solution is doable.