digdag icon indicating copy to clipboard operation
digdag copied to clipboard

Fix rerun_on description for document

Open y-ken opened this issue 5 years ago • 5 comments

follow-up for https://github.com/treasure-data/digdag/commit/dbc12e40fc86a3a0f0552a921b380c0f9dd55b72#diff-828f306a0ac2fd6cd570c28c4b2f1cd2

yoyama 17:54 The document is misleading. The description only focus when attempt already exists. If no attempt for the session time, require> always kick the child workflow.

context: https://treasure-data.slack.com/archives/C094GC4JK/p1594110936030000

y-ken avatar Jul 07 '20 11:07 y-ken

@LeenSun could you please take a look?

y-ken avatar Jul 08 '20 14:07 y-ken

@yoyama Updated PR, Would you please take a look?

y-ken avatar Oct 29 '20 10:10 y-ken

@yoyama I have updated doc as you suggested. 🙆‍♂️

y-ken avatar Oct 30 '20 07:10 y-ken

As result of large change in master branch, there are many conflicts happened. Could you resolve it ?

yoyama avatar Dec 24 '20 08:12 yoyama

@yoyama I have fixed conflicts. please take a look

y-ken avatar Dec 24 '20 09:12 y-ken