protobuf-zig icon indicating copy to clipboard operation
protobuf-zig copied to clipboard

ci: zig/protobuf-zig/: No such file or directory

Open travisstaloch opened this issue 1 year ago • 6 comments

https://github.com/travisstaloch/protobuf-zig/actions/runs/9559522253/job/26350006190

Not sure whats causing this. Could be the change to https://github.com/mlugg/setup-zig.

TODO - get rid of the sdk step stuff in build.zig and instead do something like https://ziglang.org/learn/build-system/#running-the-projects-tools

travisstaloch avatar Jun 18 '24 06:06 travisstaloch

it seems the zig-out/bin/protoc is not executable -rw-r--r-- protoc

mindon avatar Aug 09 '24 08:08 mindon

Oh thank you! That sounds like it might be the issue. I guess that either zig's zip impl or the build system doesn't preserve file executable bits. So they would have to be manually set.

travisstaloch avatar Aug 09 '24 21:08 travisstaloch

it seems the zig-out/bin/protoc is not executable -rw-r--r-- protoc

@mindon I can't reproduce on linux. What OS are you seeing this from?

$ rm -rf .zig-cache/ zig-out/ && zig build && ls -lah zig-out/bin/
-rwxrwxr-x 1 9.0M Aug  9 15:11 protoc

travisstaloch avatar Aug 09 '24 22:08 travisstaloch

it seems the zig-out/bin/protoc is not executable -rw-r--r-- protoc

@mindon I can't reproduce on linux. What OS are you seeing this from?

$ rm -rf .zig-cache/ zig-out/ && zig build && ls -lah zig-out/bin/
-rwxrwxr-x 1 9.0M Aug  9 15:11 protoc

I'm using M1 with MacOS Sonoma 14.4.1 (23E224), zig (0.14.0-dev) build failure on following error error: unable to spawn /Users/hello/protobuf-zig/zig-out/bin/protoc: AccessDenied

mindon avatar Aug 12 '24 02:08 mindon

~~Hmm not sure why this is happening. Could you try manually downloading the files from https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protoc-27.0-osx-universal_binary.zip and check if the unzipped files are executable? This way we could check if this is a problem with their zip files.~~

travisstaloch avatar Aug 12 '24 02:08 travisstaloch

Don't worry about my last request @mindon. I asked about this on discord and it seems like execute permissions support hasn't been added to the zig zip implementation yet. I created an issue for this https://github.com/ziglang/zig/issues/21044.

travisstaloch avatar Aug 12 '24 03:08 travisstaloch