travisstaloch
travisstaloch
> Can you edit your PR description to be correct so that I can use it for release notes in the future? Thanks! Done. And will do.
I'm wondering if this issue should be re-opened. The limit was [previously hard coded at 1500](https://github.com/ziglang/zig/pull/19719/files#diff-21d30ce0013f5ece957e6aaf22b08bbee6484c02f994bf146db7c9cb32d9cbf5L48) but I changed it in that PR to be dependent on [kvs_list.len](https://github.com/ziglang/zig/blob/master/lib/std/static_string_map.zig#L73). The multiplier...
> Since the KVs are sorted, a linearly-growing bound will never be sufficient for extreme cases. Perhaps grow proportional to n^2 or something? Thanks, sounds good! Checking if test-std passes...
> Since the KVs are sorted, a linearly-growing bound will never be sufficient for extreme cases. Perhaps grow proportional to n^2 or something? Done.
> If StaticStringMap was recently changed to be N^2 then it needs to be reverted pronto The comptime initialization has not changed significantly from the original ComptimeStringMap impl. The limit...
Sounds good. I will update the limit to C * N * log2(N).
Just pushed a change. Now using `math.log2_int_ceil(usize, kvs_list.len)` instead.
Note: this regressed sometime in the last week or so. It was working prior to then. I discovered because of this ci failure: https://github.com/travisstaloch/protobuf-zig/actions/runs/5300787367/jobs/9594532718
maybe a more direct reproduction: ```zig pub const Ok = enum(u32) { a, b, c }; pub const Nok = enum(i32) { a, b, c }; test { _ =...
~~this is not a bug. the crash happens because. the slice is undefined. this is an issue tracker, not a place to ask questions. these types of questions should be...