travisstaloch

Results 69 comments of travisstaloch

should I leave in `initRuntime()`? if so, should I rename it to `init()` now?

> Could the name be changed while we're breaking the API? Instead of `ComptimeStringMap` with `initRuntime` have something like `StaticStringMap` with `initComptime`? This is done. We'll see how many typos...

CI doesn't like that I've renamed `lib/std/comptime_string_map.zig` to `lib/std/static_string_map.zig` ``` ninja: error: '../lib/std/comptime_string_map.zig', needed by 'zig2.c', missing and no known rule to make it ```

> CI doesn't like that I've renamed `lib/std/comptime_string_map.zig` to `lib/std/static_string_map.zig` For now, I've moved back to the original name so we can make progress.

> I think you need to also change this line (in samencommit), so that CMake knows this "dependency" is renamed: Thanks! Just pushed this change.

Sounds good! Thats an easy change. Also, any thoughts about whether I should remove `getPartial()`? I found it very useful for tokenizing or parsing to have a way to check...

> `getMaxPrefix` Not bad. I think I'd prefer `getLongestPrefix()` :thinking:

> That's what I was going for. @Vexu done - renamed `initRuntime()` to `init()`. Also renamed `getPartial()` to `getLongestPrefix()` and cleaned up tests and documentation a little more. I removed...

Perf point: building my simdjzon project with around 7000 loc zig files in src folder. Note that I'm not super confident in my process so here are some notes: *...

> Perf point: building my simdjzon project with around 7000 loc zig files in src folder. I got some feedback on discord from @jacobly0 @nektro and `@Sinon` (sorry forget your...