DevTipsShowWebsite icon indicating copy to clipboard operation
DevTipsShowWebsite copied to clipboard

Site is broken when viewed through github pages

Open jlndk opened this issue 10 years ago • 5 comments

When i tried to view the site, through the link http://travisneilson.github.io/DevTipsShowWebsite, the website weren't styled properly.

It looked like this: screencapture-travisneilson-com-devtipsshowwebsite-1459336768299

jlndk avatar Mar 30 '16 11:03 jlndk

It is a matter of links: you just need to remove the slash from the path to the main stylesheet for the homepage - for the other pages just add two dots at the root.

<link href="assets/css/main.css" rel="stylesheet"> and <link href="../assets/css/main.css" rel="stylesheet">

link-fixing-one link-fixing-two

It depends on Travis..

andrealeone avatar Mar 30 '16 12:03 andrealeone

I'm going to "relativize" paths in a separate branch to pull.

andrealeone avatar Mar 30 '16 12:03 andrealeone

How big of an issue is this? I didn't even consider this use case because, why would anyone go there?

travisneilson avatar Apr 01 '16 04:04 travisneilson

Yeah, you're right.. I did't think about it. --It is still fun and a pleasure to try to fix bugs.

andrealeone avatar Apr 01 '16 14:04 andrealeone

Since this website is properly going to be viewed by many of your viewers, i think it would be a good little fix, considering how little time it takes :).

jlndk avatar Apr 01 '16 22:04 jlndk