Travis Nielsen

Results 477 comments of Travis Nielsen
trafficstars

Oh right, I linked the wrong chart. Did you create the rook-ceph-cluster chart, or only the rook-ceph chart?

Ok, I understand now that the helm charts created the needed SCCs. However, I'm not clear why you needed to add `rook-ceph-default` and `rook-ceph-mgr` to the `privileged` SCC, since the...

Ok I see, we will need to allow configuration of the `allowHostNetwork` in the helm chart.

@obnoxxx We should be able to replace [lines 11-14 in securityContextConstraints.yaml](https://github.com/rook/rook/blob/master/deploy/charts/rook-ceph-cluster/templates/securityContextConstraints.yaml#L11-L14) of the cluster chart templates with something like the following condition (but I haven't tested it): ```yaml {{- if...

typo? :) `housewarming --> allowHostNetwork` Sounds like we need to make these two settings configurable instead of always false. The comments indicate the same, but was not implemented yet in...

@EdwardCooke I went ahead with the change, please review #16343

LGTM, @Rakshith-R please also review

@Madhu-1 Any more feedback on this?

@yaguangtang @haslersn I've rebased this and believe it's ready to merge. Thanks @haslersn for validating. @parth-gr Any other testing needed?