Travis Nielsen

Results 478 comments of Travis Nielsen
trafficstars

@thotz There are a number of old comments and questions on this PR, what is the status? According to the discussion in #4315, there is still interest in completing this...

Closing in favor of #11091

Correct, any change to the OSD pod spec will lead to a restart. If you change that value, why would you not expect the OSD to restart?

Oh, the issue is that you expected 2048 to be applied to that vdc OSD on node01, but instead you see 1024?

Ok, I ran a quick test, and I see that the `config` is not being applied from the individual device section. The `config` is only honored from `storage.config`, or under...

> @travisn What is the role of databaseSize in the environment variable of osd pod? Is it possible to remove from environment variables? In the [default cluster.yaml example](https://github.com/rook/rook/blob/master/deploy/examples/cluster.yaml#L231), this setting...

> I mean it is only removed from the environment variables of the osd pod and kept in the cluster.yaml. Because the prepare job needs to specify the metadata size...

Yes, I expect it will be ignored since it's only used during provisioning.

> > Yes, I expect it will be ignored since it's only used during provisioning. > > @travisn Would you allow me to submit a pr for this issue Certainly!...

> > > > Yes, I expect it will be ignored since it's only used during provisioning. > > > > > > > > > @travisn Would you allow...