jocko
jocko copied to clipboard
refactor dockerfile, go modules with golang v1.14.2; closes #163
trafficstars
-
removed dep-related comands and notes
-
added two Dockerfiles (works with Podman, Buildah too)
- "prod": for clean build, with tests, runnng with non-root user, from scratch container
- "dev": there is caching for golang deps, without tests, run as root, and result container can be not from scratch, for debug reasons.
-
docker-compose file:
- added shared context-build block, DRY.
- removed command name
jockoin linecommand: jocko broker...because of we are using the same ENTRYPOINT in docker file.
-
small fixes in module paths:
- "github.com/hashicorp/consul/testutil/retry" -> "github.com/hashicorp/consul/sdk/testutil/retry"
-
update go.mod to the lastest version for all transitive deps (exepts github.com/mitchellh/go-testing-interface v1.4.0)
@BOPOHA this looks good tho i don't think we should run the tests in the main dockerfile, maybe create a separate one called Dockerfile-test