trackerific icon indicating copy to clipboard operation
trackerific copied to clipboard

[green] USPS tracking now working

Open zackshapiro opened this issue 11 years ago • 7 comments

  • Completely re-wrote the date method that was the source of many failures. The thing that was causing the error was a hardcoded look for a certain range. With the re-write, it looks for the month in the array and uses it's index as the starting value for the date. It then goes either 2 or 4 places deeper in the array to get the full date based on whether AM or PM is present in that index.
  • Re-wrote the description method to detect the description more simply. The format is always a description, followed by a comma, so I'm just splitting on the first comma. Tried this with a few data sets, works well. They never use commas in the description
  • Removed excess comma from city, state, zip. They now include it in the city string
  • In the location method, detecting whether or not the location is present. If not, returning an empty string for location.
  • Was unable to get specs to run, said there were zero specs when that's not true. Rewrote method to be more accurate in detection
  • Closes #8
  • Still needs tagging update, will leave that to you @travishaynes

zackshapiro avatar Nov 23 '13 19:11 zackshapiro

Coverage Status

Coverage decreased (-1.37%) when pulling cefe28ca4d22ed5f3a2a3e029494e3a441d706ad on zackshapiro:0.7.6 into 1c8fd4cd73d36ed70f18f5a63bc3b404788f3682 on travishaynes:master.

coveralls avatar Nov 23 '13 19:11 coveralls

Coverage Status

Coverage decreased (-1.37%) when pulling cefe28ca4d22ed5f3a2a3e029494e3a441d706ad on zackshapiro:0.7.6 into 1c8fd4cd73d36ed70f18f5a63bc3b404788f3682 on travishaynes:master.

coveralls avatar Nov 23 '13 19:11 coveralls

Coverage Status

Coverage decreased (-1.37%) when pulling cefe28ca4d22ed5f3a2a3e029494e3a441d706ad on zackshapiro:0.7.6 into 1c8fd4cd73d36ed70f18f5a63bc3b404788f3682 on travishaynes:master.

coveralls avatar Nov 23 '13 19:11 coveralls

Coverage Status

Coverage decreased (-2.65%) when pulling 9dec4f98946e595df7a42331d89a03171898030e on zackshapiro:0.7.6 into 1c8fd4cd73d36ed70f18f5a63bc3b404788f3682 on travishaynes:master.

coveralls avatar Nov 24 '13 17:11 coveralls

Coverage Status

Coverage decreased (-2.65%) when pulling d0e8ccb912cbf23eabba670bbfe1fff5d659e489 on zackshapiro:0.7.6 into 1c8fd4cd73d36ed70f18f5a63bc3b404788f3682 on travishaynes:master.

coveralls avatar Nov 24 '13 17:11 coveralls

@travishaynes Bumping this

zackshapiro avatar Dec 01 '13 23:12 zackshapiro

Any action on this?

zackshapiro avatar Dec 10 '13 22:12 zackshapiro