argo-cd-helmfile icon indicating copy to clipboard operation
argo-cd-helmfile copied to clipboard

Image tag version based on helmfile version

Open agershman opened this issue 1 year ago • 2 comments

When using the built container image as an Argo CD repo server sidecar plugin, it feels like it would be more intuitive to have the image tag contain the version of helmfile in it (e.g. 0.167.1-1). I do see that there are other things included in the Dockerfile which could be changed and affect functionality without having to change the version of helmfile itself. For this reason, I think it could be address by tacking a simple incrementing number to the helmfile version (...-1 in the example). Though there are multiple pieces of software in the container, it's really helmfile that's the centerpiece. Curious if this has been considered or what the thoughts are around this?

agershman avatar Aug 30 '24 23:08 agershman

I agree. Especially now that Helmfile v1.0.0 with some breaking changes is about to be released, logically this would require a major version bump for the plugin as well, and since it would bring it into v1.x.x territory it makes a lot of sense to just align the versions.

crabique avatar Mar 09 '25 12:03 crabique

Now that v1.0.0 is released and it breaks some backwards compatibility, @travisghansen would it make sense if the versions for new releases would be matching the helmfile version?

crabique avatar May 07 '25 09:05 crabique