Results 376 comments of Travis Downs

> I think this raises the question "What should be fsync'd?". Imagine `fsync=2` and due to round robin I've written to two separate files: do I now generate two fsync()...

This was discovered due to very poor throughput between a remote client with ~250 rtt and Redpanda: this transfer is receive window limited and benefits from buffers > 1 MB,...

@nyh wrote: > Looks good, I just have a comment about a typo, and one nitpick about the test: I think it's better to test with **different** send and receive...

@nyh - all feedback addressed, please have a look when you have a chance, thanks!

@tchaikov wrote: > probably you meant python 3.6? as python 3.9 was released 4 years ago, see https://www.python.org/downloads/release/python-390/ . Ooops sorry you are right. I was confusing two things: type...

@nyh wrote: > Will "type annotations" help anything? My biased opinion is that type hints are very useful and low overhead and a net positive for anything which is non-trivial...