Results 370 comments of Travis Downs

Yes, but that's the _bread and butter_ of portable snippets, right? The work is done here so users don't have to do it :)

You are right that clang up to the current version (4.0?) anyway doesn't seem to have any rotate intrinsic. I had seen it reported that they did, but it must...

I think using the C rotate idiom that `clang` already recognizes is the best for `clang`: ``` unsigned rotl_c(unsigned a, unsigned b) { b &= 31; return (a > (32...

Yup, I'm already building with `cpu.c` fine in my project, but a summary of this info would definitely be good for new users I think.

If you're on Linux x86, you can also consider [`uarch-bench`](https://github.com/travisdowns/uarch-bench) to test the "raw" performance of loads/stores of various size and misalignments, perhaps as a baseline to compare to the...

Right, it makes sense. I do want to support other mainstream archs on uarch bench, but that probably mostly just means ARM.

@bhalevy this may also be in your wheelhouse.

Thanks for the review @bhalevy, much appreciated.

If the user specifies `--memory` and `--reserve-memory` at the same time, is the only use of `--reserve-memory` in that scenario to do the startup check & emit error if the...

The CI failure looks spurious, probably this one: https://github.com/scylladb/seastar/issues/1127