erlang-uuid icon indicating copy to clipboard operation
erlang-uuid copied to clipboard

Published 20 hours ago • verified publisher icon travis

Use bit shifting instead of math:power

Open snluu opened this issue 12 years ago • 6 comments

snluu avatar Feb 09 '13 21:02 snluu

looks like a good idea, but the patch I just merged conflicts - please update if you'd like to get this in

travis avatar Mar 28 '13 14:03 travis

I have merged the changes. Please review and pull. Thanks!

snluu avatar Mar 29 '13 02:03 snluu

don't we still want to stick with crypto:rand_uniform per @shoehn's changes here: https://github.com/travis/erlang-uuid/pull/4 ?

travis avatar Mar 29 '13 13:03 travis

Sorry about that. I included those changes and removed the -1's.

snluu avatar Mar 29 '13 14:03 snluu

ok great. @robertoaloi @shoehn would you mind taking a look too? I'm far enough out from all of this that I'm not 100% sure this is right. if you don't get to it I'll test it sometime soon and get it merged. thanks for the patch @sluu99 !

travis avatar Mar 29 '13 15:03 travis

shoot, haven't gotten to this yet and it looks like it's become unmergable in the mean time - could you update this PR to make it mergable? thanks!

travis avatar Apr 14 '13 19:04 travis