travis-web icon indicating copy to clipboard operation
travis-web copied to clipboard

add default view and loading indicator to repos without builds

Open emmanuel-ci opened this issue 5 years ago • 4 comments

Ticket for this: https://travisci.assembla.com/spaces/Web/tickets/realtime_cardwall?ticket=246

emmanuel-ci avatar Nov 27 '19 15:11 emmanuel-ci

Hey @emmanuel-ci, thanks for working on this! What do you think about adding an image and some kind of a direction how to proceed to get the section filled (like a link to docs, for example)? Something like we already have for repo page: https://travis-ci.com/artursmirnov/broccoli-scss-lint. So that the page didn't look too empty.

artursmirnov avatar Jan 20 '20 16:01 artursmirnov

Fantastic idea @artursmirnov - it turns out we already have a <NoBuilds/> component. Simple & straightforward. 🎉

emmanuel-ci avatar Jan 20 '20 17:01 emmanuel-ci

@emmanuel-ci, it's a great idea to reuse existing component here 👍 Although, it seems like it doesn't work well out of the box and needs some adjustments:

image

It says "No builds for this repository", whereas "My Builds" combines builds from many repositories.

Also "Want to start testing this project" doesn't sound right as well.

artursmirnov avatar Jan 21 '20 16:01 artursmirnov

Oh yea, I've adjusted the component a bit. Also, while working on this, I noticed when the builds are loading from the API there is no loading indicator present - so it shows the default message You have no builds yet, and when the builds finish loading from the API, it renders them, which is quite confusing.

emmanuel-ci avatar Jan 21 '20 18:01 emmanuel-ci