dpl icon indicating copy to clipboard operation
dpl copied to clipboard

Pages target dir

Open adrianbroher opened this issue 5 years ago • 2 comments

This PR tries to take a stab at #1164.

Never did anything related to ruby, so feedback is appreciated.

adrianbroher avatar Feb 23 '20 11:02 adrianbroher

am wondering if the log output will be very useful if we omit the work dir from it

I can add another message to the setup method.

and i'm not sure we need the dst_dir method at all if it's just eqal to target_dir

I actually wanted to add a guard/limitation so that target_dir can only be a descendant directory of work_dir. However I have yet to find out how to implement this in ruby and if the accessor is the right place for this or if this opt thing allows validators.

have you been able to test this with an actual deployment?

No, but I created this test repository.

adrianbroher avatar Feb 26 '20 19:02 adrianbroher

While looking at the log of the build it may be a good idea to call git add -A %{dst_dir} instead of git add -A ..

adrianbroher avatar Feb 26 '20 19:02 adrianbroher