fedora-coreos-matrix icon indicating copy to clipboard operation
fedora-coreos-matrix copied to clipboard

Published 20 hours ago • verified publisher icon travier

Generated secrets do not work well with sed

Open laolux opened this issue 4 years ago • 5 comments

I followed your instructions and synapse generated a secret which would not work well with sed in the makefile. Namely, I got a synapse_macaroon_secret_key like abc&def. Seems like sed does not like the & in there. Unfortunately I do not know enough about sed to fix this.

Anyways, I could still run everything by simply generating new secrets which did not contain any &. Thanks for the great project!

laolux avatar Jan 23 '21 13:01 laolux

Thanks for the feedback! Indeed, the way we template secrets is not ideal and does not cover all cases. We tried to find the easiest solution that everyone would have already installed but that may not be the best choice long term. Maybe we should look at a real template language.

travier avatar Jan 26 '21 17:01 travier

Yes, I guess some template language could help. I just ran into another issue: Passwords containing # get cut off short. This can be really dangerous, because it could lead to very very short passwords and you do not find those if you do not check the generated homeserver.yaml. Maybe put a warning about that into the README?

laolux avatar Jan 27 '21 06:01 laolux

I'm taking a look at tera-cli which is based on tera which is inspired by Jinja2 so should be easy to use in our case.

travier avatar Jan 27 '21 19:01 travier

That sounds good to me, but might entail some new dependencies. I currently do not have the time to get myself started with tera, so I made a small pull request #15 to point others to this potential pitfall. I am happy to assist trying out tera when you (or someone else) has started implementing it.

laolux avatar Jan 31 '21 08:01 laolux

Note for later: revert https://github.com/travier/fedora-coreos-matrix/pull/15 when done.

travier avatar Feb 01 '21 19:02 travier