Trask Stalnaker

Results 1261 comments of Trask Stalnaker

Another advantage of rule sets is we can set org-level rule set (e.g. for EasyCLA)

Note: I'm officially giving up on Rulesets until https://github.com/orgs/community/discussions/61107#discussioncomment-6569780 is fixed 😞

Starting to track associated errors in case they are useful: ``` Elasticsearch6NodeClientTest > test elasticsearch get[0] FAILED java.lang.AssertionError: Thread [elasticsearch[default node name][masterService#updateTask][T#1]] opened a scope of {opentelemetry-trace-span-key=RecordEventsReadableSpan{traceId=1551d3e6b043be93c1b2dbd4457d9ba9, spanId=620f959ffafc836a, parentSpanContext=ImmutableSpanContext{traceId=00000000000000000000000000000000, spanId=0000000000000000,...

``` Mongo4ReactiveClientTest > test create collection FAILED java.lang.AssertionError: Thread [AsyncGetter-1-thread-1] opened a scope of {opentelemetry-trace-span-key=RecordEventsReadableSpan{traceId=342add72e4a4ec95c7cc41621f324771, spanId=4a73de3e7903d89d, parentSpanContext=ImmutableSpanContext{traceId=00000000000000000000000000000000, spanId=0000000000000000, traceFlags=00, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=false}, name=parent, kind=INTERNAL, attributes=null, status=ImmutableStatusData{statusCode=UNSET, description=}, totalRecordedEvents=0, totalRecordedLinks=0, startEpochNanos=1629771066420432133,...

@krismarc do I understand from https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/12240#issuecomment-2414338027 that issue is resolved? thanks

Discussed in db semconv meeting, and suggestion is to keep `db.query.parameter.` and introduce `db.query.parameter.type.`

there could be overlap if there is a `` named `type` not as nice, but a workaround could be `db.query.parameter_type.`

> we can declare `db.query.parameter.` to have `any` value I think this also gives us a solution to capturing null values (I think `any` attributes support null value while string...

hi @xiepuhuan! yes, let's start with just one (pick any), so we can work through any issues/concerns, and then you could do the rest in a single follow-up PR if...