Johan Cwiklinski

Results 305 comments of Johan Cwiklinski

Is there a reason to keep errors in new methods names? `datas` is not correct, new methods should be correct I guess :) Also, I think tests should be added...

Please try with latest nightly build, it should have been solved (search on existing issues/pr to get the reference, I do not have time for that).

As requested, please use english only.

Several fixes has been done since 10.0.3 release on that part, please test if you reproduce with latest nightly build.

Let's see if actual tests are fixed; but I guess new handled cases must be added in tests suite.

> > Let's see if actual tests are fixed; but I guess new handled cases must be added in tests suite. > > Should i delete ` $val->model = $model;`...

Also, Asset\NetwokrEquipment extends Asset\MainAsset, and `model` property seems used there as well. I guess it's a bad idea to remove it for some cases.

I cannot push on your branch. Please find attached a patch to fix tests. [0001-Fix-tests.zip](https://github.com/glpi-project/glpi/files/9674585/0001-Fix-tests.zip)