trase icon indicating copy to clipboard operation
trase copied to clipboard

fmt

Open fcooper8472 opened this issue 5 years ago • 2 comments

@martinjrobins just playing around with {fmt}. Not suggesting we should use it, but wanted an excuse to have a go with it.

It seems very nice! And you can put {} injections inside raw string literals which is very nice for writing svg elements that otherwise need escaped " characters. Has nice clean float precision options, too.

The fmt::format matches std::format that was introduced in C++20.

fcooper8472 avatar May 08 '20 23:05 fcooper8472

Codecov Report

Merging #141 into master will decrease coverage by 27.10%. The diff coverage is 26.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #141       +/-   ##
===========================================
- Coverage   87.85%   60.75%   -27.11%     
===========================================
  Files          48       52        +4     
  Lines        2199     4079     +1880     
===========================================
+ Hits         1932     2478      +546     
- Misses        267     1601     +1334     
Impacted Files Coverage Δ
src/fmt/format.cc 0.00% <0.00%> (ø)
src/fmt/format.h 31.65% <ø> (ø)
src/fmt/format-inl.h 20.68% <20.68%> (ø)
src/fmt/core.h 49.28% <49.28%> (ø)
src/backend/BackendSVG.cpp 74.16% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 607404c...07281cb. Read the comment docs.

codecov[bot] avatar May 08 '20 23:05 codecov[bot]

that does look really nice! I'd be happy to start using this, but would require a bit of work upfront to convert everything

martinjrobins avatar May 23 '20 07:05 martinjrobins