mergerfs icon indicating copy to clipboard operation
mergerfs copied to clipboard

Published 20 hours ago • verified publisher icon trapexit

Prevent no branches

Open rienafairefr opened this issue 3 years ago • 10 comments

as discussed in #1073, this seems to fix it.

returns "not supported" ENOTSUP when a change would result in no branches. incidentally, the code for branches from_string was already raising/erroring out in case of setting completely empty branches, that's fixed. I've added unit test cases to test all that.

On my system, the -fsanitize=undefined option in the compiler added some problems that seem to be fixed by also adding the -fsanitize=undefined flag on linking, not sure why, that's why the change is in there,

rienafairefr avatar Oct 09 '22 17:10 rienafairefr

This pull request fixes 1 alert when merging f2bb6495b4e0c043ef759abf5fcc4646fb3040e7 into 5d3c5002e09c50598d4dfb86b6894f7e836e7e85 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

lgtm-com[bot] avatar Oct 09 '22 17:10 lgtm-com[bot]

Sorry I think I broke the CI with é in my last name 😅

rienafairefr avatar Oct 09 '22 17:10 rienafairefr

Yeah. Perhaps my script could be setup to decode utf8.

Try changing .decode() in git2debcl to .decode('utf-8')

trapexit avatar Oct 09 '22 17:10 trapexit

This pull request fixes 1 alert when merging ad6c93f8cc2e4df19bc0611c3c66c5d5b0f8ed3f into 5d3c5002e09c50598d4dfb86b6894f7e836e7e85 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

lgtm-com[bot] avatar Oct 09 '22 20:10 lgtm-com[bot]

This pull request fixes 1 alert when merging 5d61a5b0ddbdd04eb2fd5ed9a657fd8bf8e9717f into 5d3c5002e09c50598d4dfb86b6894f7e836e7e85 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

lgtm-com[bot] avatar Oct 09 '22 21:10 lgtm-com[bot]

This pull request fixes 1 alert when merging 80e07522a825b794d8a094c58e9fe5716e807861 into 5d3c5002e09c50598d4dfb86b6894f7e836e7e85 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

lgtm-com[bot] avatar Oct 09 '22 22:10 lgtm-com[bot]

This pull request fixes 1 alert when merging 694b81948ceb5ee4da6ea1c6f5a830919066583a into 5d3c5002e09c50598d4dfb86b6894f7e836e7e85 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

lgtm-com[bot] avatar Oct 10 '22 18:10 lgtm-com[bot]

This pull request fixes 1 alert when merging f283cba719e62a58d1b6ccd8c615c301c4921f8f into 5d3c5002e09c50598d4dfb86b6894f7e836e7e85 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

lgtm-com[bot] avatar Oct 10 '22 19:10 lgtm-com[bot]

Ugh. Sorry. Python is a major pita regarding char encoding. I can try to fix it and then you can submit the PR for the original issue. Or if you want to see it through feel free.

trapexit avatar Oct 10 '22 22:10 trapexit

Can't you just set the ENV to UTF-8 encoding? Either through PYTHONIOENCODING="UTF-8" or the LANG/LANGUAGE/LC_ALL?

saltydk avatar Mar 29 '23 10:03 saltydk