verifiable-data icon indicating copy to clipboard operation
verifiable-data copied to clipboard

What's the presentation exchange specification using in this project?

Open thomas-tran opened this issue 3 years ago • 4 comments

Hi @OR13 ,

I noticed that there are 2 standards below. Which one is using on this project? https://identity.foundation/presentation-exchange/ and https://identity.foundation/waci-presentation-exchange/

Do you have a complete example how to create the presentation definition as I can only see the example how to create the presentation credential?

Thanks Thomas

thomas-tran avatar Nov 15 '21 23:11 thomas-tran

We don't have one in this repo... @brianorwhatever have a better source?

Maybe checkout https://github.com/aviarytech/didcomm

OR13 avatar Nov 15 '21 23:11 OR13

The code isn't too clean but this is the project we were hacking together to create wacinstein https://github.com/aviarytech/wacinsteins-monster

you can see the presentation entity structures here https://github.com/aviarytech/wacinsteins-monster/blob/main/backend/src/presentations/entities/presentation.entity.ts

and them being created in this service https://github.com/aviarytech/wacinsteins-monster/blob/main/backend/src/presentations/presentations.service.ts

brianorwhatever avatar Nov 16 '21 05:11 brianorwhatever

@brianorwhatever Thanks for the instruction, I looked at the code and it seems the presentation entity did not match the schema here https://identity.foundation/presentation-exchange/#term:presentation-definition. For example, in the input descriptor the purpose, format, group and name are missing and the schema field is required which I did not see the explanation from document. Do you have a test example on the wacinsteins-monster project?

thomas-tran avatar Nov 16 '21 06:11 thomas-tran

ah yes I see that you are definitely right. apologies this was pretty hacked together code and not tested well. I have moved onto other things now and put this proof of concept down for the time being. I am planning on validating against the json schema from the waci-pex spec here https://identity.foundation/waci-presentation-exchange/#presentation-exchange-context. That would have caught the missing schema prop. The only difference between this json schema and the one in the main presentation exchange spec is the frame property which it looks like is now included in the presentation exchange spec.

brianorwhatever avatar Nov 16 '21 18:11 brianorwhatever