solmate icon indicating copy to clipboard operation
solmate copied to clipboard

Published 20 hours ago • verified publisher icon transmissions11

✨ LibString tests and toHexString functions

Open Vectorized opened this issue 3 years ago • 7 comments
trafficstars

Description

This is for #245.

Added some to hex functions.

Added some minor optimizations.

Added some tests.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • [x] Ran forge snapshot?
  • [x] Ran npm run lint?
  • [x] Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Vectorized avatar May 21 '22 22:05 Vectorized

https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3573/files

is this version more optimized?

transmissions11 avatar Jul 31 '22 08:07 transmissions11

@transmissions11 nope.

Vectorized avatar Jul 31 '22 14:07 Vectorized

chad

transmissions11 avatar Jul 31 '22 19:07 transmissions11

Can this be merged? 👀

axic avatar Oct 23 '22 21:10 axic

Lemme copy in the latest version.

Vectorized avatar Oct 23 '22 21:10 Vectorized

lgtm

androolloyd avatar Oct 27 '22 15:10 androolloyd

Updated with latest Solady implementations.

Feel free to copy or delete anything directly from Solady anytime.

Tests may be harder to be ported fully, cuz Solady uses a different brutalizer and brutalized tests.

Vectorized avatar Oct 28 '22 00:10 Vectorized