t11s issues

Results 112 issues of


                                            t11s

💥 v1.1

- [x] Event fixes - [x] Comment fixes - [x] Update `calldataByteGasEstimate` to 12 gas - [ ] Don't allow executing the same request twice on the execution manager -...

📝 Document why relayers need to simulate even if safe strategy

I believe the answer because the gas limit could be set too low? Tho maybe they can validate this off-chain in advance and not need to simulate?

🔒 DOS if request creator is a contract that reverts when sent ether via execCompleted

♻️ Checks msg.value ==, should do >= and change error to NOT_ENOUGH_ETH (instead of BAD_ETH_VALUE)

⚡️ Make unimportant constants and state variables internal

♻️ Rename “NOT_UNLOCKED” to “TOKENS_NOT_UNLOCKED”

♻️ Change all use of execute -> relay

- Executors -> Relayers - Exec -> Relay etc

♻️ Try refactoring use of storage pointers into cached memory

♻️ Use ternary to simplify nested if statements

Noticed this first in the approval escrow