transmission icon indicating copy to clipboard operation
transmission copied to clipboard

Add privacy filter for webui (filter torrents by private/public status)

Open dareiff opened this issue 11 months ago • 10 comments

Originally from #4423. This is mostly from @WillDaSilva, but I changed a few things:

  • slight UI change (&nbsp to --) as separator
  • deduplicate 'All'
  • filterTracker expression was wrong

I can’t seem to tag @WillDaSilva as coauthor, for some reason.

dareiff avatar Mar 25 '24 18:03 dareiff

@dareiff Thank you for making this!

If you would like to add me as a co-author, you can rebase the first commit of this PR so as to edit its commit message to end with:

Co-authored-by: Will Da Silva <[email protected]>

WillDaSilva avatar Mar 25 '24 22:03 WillDaSilva

Thanks. Don't forget to undraft your pull request when ready for review.

Coeur avatar Mar 26 '24 00:03 Coeur

@dareiff Thank you for making this!

If you would like to add me as a co-author, you can rebase the first commit of this PR so as to edit its commit message to end with:

Co-authored-by: Will Da Silva <[email protected]>

Thanks for that! Got it in.

dareiff avatar Mar 28 '24 14:03 dareiff

OK, ready for review @tearfur.

dareiff avatar Mar 28 '24 14:03 dareiff

Styling items in dropdown is not supported under some browsers. You can just remove styles resulting in only hyphens in the dropdown.

For some sites that may be using "private" and "public" in their domain, mai I suggest we prepend them with "is:", as so: "is:private", "is:public", my custom client has "is:" to all status dropdown while the "tr:" is given to trackers so these can be combined into a single dropdown and I'll have no problem segregating them when filtering torrents.

Rukario avatar Mar 29 '24 19:03 Rukario

Styling items in dropdown is not supported under some browsers. You can just remove styles resulting in only hyphens in the dropdown.

Yeah I’m not sure exactly why that inline style was there, but everything looked normal in my browsers so I didn’t even think to remove it.

dareiff avatar Mar 29 '24 20:03 dareiff

For some sites that may be using "private" and "public" in their domain, mai I suggest we prepend them with "is:", as so: "is:private", "is:public"

I like it 👍🏻

@dareiff Unless you have something else to say/suggest, please update this PR according to Rukario's suggestion.

tearfur avatar Mar 30 '24 03:03 tearfur

@Rukario AFAIK All modern browsers support some level of styling select boxes. But inline styles should be avoided anyway.

killemov avatar Apr 16 '24 23:04 killemov

Hello, it looks like this PR is in limbo of not updating, are you going to do about it? This is great feature BTW.

Rukario avatar Jun 24 '24 21:06 Rukario

I can see the benefit of using both private flag and torrent status to each other but I think the private flag should be moved to status select box to make more sense code-wise and for one of the future PRs aiming to tackle the obstacle of limited options in filtering torrents. It will be harmonious with using "is:" on all status from different places of a torrent. Private flag is just another status type belonging to private trackers.

Rukario avatar Jul 06 '24 01:07 Rukario