transmission
transmission copied to clipboard
transmission
feat: display percent in progress bar for web client
Old screenshot
Animated diff from original
Notes: Added percent digits into the progress bar.
@Rukario sorry for leaving this in code review limbo for so long, I'd like to get this PR unstuck. Could you update this & resolve the scss conflicts?
@ckerr I can resolve the file conflict but there's more things this PR need to cover, particularly during contrast mode where percent will become invisible on white bar whereas non-contrast would have a light green background in the bar, I'll mark this PR WIP for now.
It's been a while I've touched my developer setup for Transmission. I'll catch up and I'll be sure to update this PR when everything is in working order with the latest Transmission.
Left: This PR, Right: Original
Old screenshot
The percent text became invisible upon the white bar under high contrast for seeding, I revised it to use the green progress bar from non-high contrast and then use black background to resolve this.
@tearfur I like your changes, it cleaned up the code a bit. I like how the paused progress bar is supposed to be the default colorless bar. That really gives different perspective.
I've applied changes manually and learned today how to co-author someone on GitHub.
My transmission setup exploded with new files, waiting for PR to finally ship so I can clean up the mess. Appreciate your feedback but I'll have to keep files maintainable. I don't have expertise with git stuff and I'm sure I don't do it quite correctly.
I like how the paused progress bar is supposed to be the default colorless bar. That really gives different perspective.
Err, what are you referring to by this? I thought my suggested changes don't modify any behaviour.
I'll leave the UI changes (particularly the colour changes in high contrast mode) for others to judge.
UI changes look good to me. Any edge cases most people don't see due to variances in sight ability can be dealt with later with color tweaks. I don't see any glaring legibility issues.
I like how the paused progress bar is supposed to be the default colorless bar. That really gives different perspective.
Err, what are you referring to by this? I thought my suggested changes don't modify any behaviour.
No changes visually don't worry about it, what I mean is a change in variable name will make you see different things.
The only changes this PR really does to the color bars is to switch from black/white to green/black to accommodate the percent text. The black bar over bright green bar looked alright. I'll be fair we don't even have color conventions for people with vision issues. There are lot of questionable color choices: The yellow bar would fade into the white background, queue and downloading blues are too similar. but as @Pentaphon said we can probably come again to recolor bars as needed another time.