transmission
transmission copied to clipboard
Please restore the old Dock icon bandwith colours
What is the issue?
Especially the new upload speed background colour is too light. It makes the speed difficult to read.
Please restore the old colours or choose colours with better contrast.
Which application of Transmission?
macOS app
Which version of Transmission?
4.0.0 (280ace12f8)
Agreed. Upload speed in particular is almost impossible to read.
Pinging the usual macOS volunteers for feedback on this idea @Coeur @nevack @sweetppro @GaryElshaw
I just upgraded to 4.0.0 and agree wholeheartedly with this suggestion. The old dark green and dark blue were much nicer and easier to read. Otherwise, a big thank you for all the work you've done!
@ckerr Happy to take a look!
By curiosity: are you on Dark or Light system colors?
By curiosity: are you on Dark or Light system colors?
I am on Light mode
Colors were changed by @livings124 with #1651. So reverting that PR from two years ago might be what you're after.
Or we could have different colors in Dark mode and Light mode eventually.
PR coming shortly...
I'm OK changing the color, but would like to keep the new simple styling.
does someone have any before after screens
Was the color change part of some larger change that we need to think about here -- e.g. are there other places that colors need to be reverted at the same time?
does someone have any before after screens
I'll make some shortly.
does someone have any before after screens
https://github.com/transmission/transmission/pull/4813/files/a4bc2e6b74d3b289fb38997860bc82bfb5e773d6..e00fc6e405a9ad70a218e614afc331b5d78508a1 shows the before and after between 4.0.0 and this PR, but of course not 3.00
are there other places that colors need to be reverted at the same time?
I don't think so. I saw the criticism of the whiteness of the text and icons of the web interface and agree with the comment that was made, it currently excels accessibility-wise and should remain as is unless something between those two values is pr-ed. Come to think of it, just turning down the monitor brightness would probably be just as effective :-)
how about we just use the apple system colors:
https://developer.apple.com/design/human-interface-guidelines/foundations/color:
{Light Mode color is shown first, then Dark mode)
the contrast looks fine in those, in my opinion
oops... I posted iOS colors.
heres macOS, Green is slightly different:
I saw the criticism of the whiteness of the text and icons of the web interface and agree with the comment that was made, it currently excels accessibility-wise and should remain as is unless something between those two values is pr-ed. Come to think of it, just turning down the monitor brightness would probably be just as effective :-)
Please move this comment to that issue :smile_cat:
oops... I posted iOS colors. heres macOS, Green is slightly different:
FWIW, this is why I trust other people to do UI review. These look so close to each other that I would never notice the difference in practice. :see_no_evil:
how about we just use the apple system colors: https://developer.apple.com/design/human-interface-guidelines/foundations/color: {Light Mode color is shown first, then Dark mode)
I think that would put us almost exactly where we currently are. Never underestimate folks liking what they like.
does someone have any before after screens
If you mean the change from 2 years ago (Transmission 3 versus Transmission 4), it's in the PR that I linked, just scroll down: https://github.com/transmission/transmission/pull/1651/files
The current green is much lighter, blue is basically the same.
Current colors are top, system (Light) colors are bottom.
The white on green of the system, i think, is still lacking in contrast but better!
Current
PR
how about the Accessible macOS system colors, they have much more contrast:
@coeur > Or we could have different colors in Dark mode and Light mode eventually.
Yep, i think that would be great.
@sweetppro That looks much better! Perfectly between the old and new, i think.
like this:
could you try these out @GaryElshaw
Heres some dark ones also for consistency:
RGB: 28, 28,30
I like the idea of those as a Dark variant with dock transparency!