transmission icon indicating copy to clipboard operation
transmission copied to clipboard

Please restore the old Dock icon bandwith colours

Open juman234 opened this issue 2 years ago • 36 comments

What is the issue?

Especially the new upload speed background colour is too light. It makes the speed difficult to read.

Please restore the old colours or choose colours with better contrast.

Which application of Transmission?

macOS app

Which version of Transmission?

4.0.0 (280ace12f8)

juman234 avatar Feb 10 '23 19:02 juman234

Agreed. Upload speed in particular is almost impossible to read.

ddbrierton avatar Feb 10 '23 19:02 ddbrierton

Pinging the usual macOS volunteers for feedback on this idea @Coeur @nevack @sweetppro @GaryElshaw

ckerr avatar Feb 10 '23 20:02 ckerr

I just upgraded to 4.0.0 and agree wholeheartedly with this suggestion. The old dark green and dark blue were much nicer and easier to read. Otherwise, a big thank you for all the work you've done!

jlhopes avatar Feb 10 '23 20:02 jlhopes

@ckerr Happy to take a look!

GaryElshaw avatar Feb 10 '23 23:02 GaryElshaw

By curiosity: are you on Dark or Light system colors?

Coeur avatar Feb 10 '23 23:02 Coeur

By curiosity: are you on Dark or Light system colors?

I am on Light mode

jlhopes avatar Feb 10 '23 23:02 jlhopes

Colors were changed by @livings124 with #1651. So reverting that PR from two years ago might be what you're after.

Or we could have different colors in Dark mode and Light mode eventually.

Coeur avatar Feb 10 '23 23:02 Coeur

PR coming shortly...

GaryElshaw avatar Feb 10 '23 23:02 GaryElshaw

I'm OK changing the color, but would like to keep the new simple styling.

livings124 avatar Feb 11 '23 00:02 livings124

does someone have any before after screens

sweetppro avatar Feb 11 '23 00:02 sweetppro

Was the color change part of some larger change that we need to think about here -- e.g. are there other places that colors need to be reverted at the same time?

ckerr avatar Feb 11 '23 01:02 ckerr

does someone have any before after screens

I'll make some shortly.

GaryElshaw avatar Feb 11 '23 01:02 GaryElshaw

does someone have any before after screens

https://github.com/transmission/transmission/pull/4813/files/a4bc2e6b74d3b289fb38997860bc82bfb5e773d6..e00fc6e405a9ad70a218e614afc331b5d78508a1 shows the before and after between 4.0.0 and this PR, but of course not 3.00

ckerr avatar Feb 11 '23 01:02 ckerr

are there other places that colors need to be reverted at the same time?

I don't think so. I saw the criticism of the whiteness of the text and icons of the web interface and agree with the comment that was made, it currently excels accessibility-wise and should remain as is unless something between those two values is pr-ed. Come to think of it, just turning down the monitor brightness would probably be just as effective :-)

GaryElshaw avatar Feb 11 '23 01:02 GaryElshaw

how about we just use the apple system colors: https://developer.apple.com/design/human-interface-guidelines/foundations/color: {Light Mode color is shown first, then Dark mode) green blue

the contrast looks fine in those, in my opinion

sweetppro avatar Feb 11 '23 01:02 sweetppro

oops... I posted iOS colors. heres macOS, Green is slightly different: green blue

sweetppro avatar Feb 11 '23 02:02 sweetppro

I saw the criticism of the whiteness of the text and icons of the web interface and agree with the comment that was made, it currently excels accessibility-wise and should remain as is unless something between those two values is pr-ed. Come to think of it, just turning down the monitor brightness would probably be just as effective :-)

Please move this comment to that issue :smile_cat:

ckerr avatar Feb 11 '23 02:02 ckerr

oops... I posted iOS colors. heres macOS, Green is slightly different:

FWIW, this is why I trust other people to do UI review. These look so close to each other that I would never notice the difference in practice. :see_no_evil:

ckerr avatar Feb 11 '23 02:02 ckerr

how about we just use the apple system colors: https://developer.apple.com/design/human-interface-guidelines/foundations/color: {Light Mode color is shown first, then Dark mode)

I think that would put us almost exactly where we currently are. Never underestimate folks liking what they like.

GaryElshaw avatar Feb 11 '23 02:02 GaryElshaw

does someone have any before after screens

If you mean the change from 2 years ago (Transmission 3 versus Transmission 4), it's in the PR that I linked, just scroll down: https://github.com/transmission/transmission/pull/1651/files

Coeur avatar Feb 11 '23 02:02 Coeur

The current green is much lighter, blue is basically the same. Current colors are top, system (Light) colors are bottom. Untitled

sweetppro avatar Feb 11 '23 02:02 sweetppro

The white on green of the system, i think, is still lacking in contrast but better!

GaryElshaw avatar Feb 11 '23 02:02 GaryElshaw

Current

SCR-20221031-nt8

PR

SCR-20230211-kxg

GaryElshaw avatar Feb 11 '23 02:02 GaryElshaw

how about the Accessible macOS system colors, they have much more contrast: Screenshot 2023-02-11 at 1 29 25 pm Screenshot 2023-02-11 at 1 29 18 pm

sweetppro avatar Feb 11 '23 02:02 sweetppro

@coeur > Or we could have different colors in Dark mode and Light mode eventually.

Yep, i think that would be great.

GaryElshaw avatar Feb 11 '23 02:02 GaryElshaw

@sweetppro That looks much better! Perfectly between the old and new, i think.

GaryElshaw avatar Feb 11 '23 02:02 GaryElshaw

like this: Untitled

sweetppro avatar Feb 11 '23 02:02 sweetppro

could you try these out @GaryElshaw

blue green blue_sm green_sm

sweetppro avatar Feb 11 '23 02:02 sweetppro

Heres some dark ones also for consistency: RGB: 28, 28,30 gray_sm gray

sweetppro avatar Feb 11 '23 02:02 sweetppro

I like the idea of those as a Dark variant with dock transparency!

GaryElshaw avatar Feb 11 '23 02:02 GaryElshaw