transmission icon indicating copy to clipboard operation
transmission copied to clipboard

Add webui privacy filters

Open WillDaSilva opened this issue 3 years ago • 1 comments

There is no issue associated with this PR yet, but I figured it'd be okay to open the PR before discussing it in an issue because of how simple the change appears to be.

This PR adds two new options to the web UI torrent list tracker filters: "Public" and "Private". As the names suggest, when "Public" is selected only non-private torrents as listed, and when "Private" is selected only private torrents are listed.

Some simple separators have also been added between "All" and the privacy options, and the privacy options and all the other trackers.

WillDaSilva avatar Dec 20 '22 19:12 WillDaSilva

Note to other reviewers: this new feature does not break the 4.0.0 i18n string freeze because the web client isn't i18nized :1st_place_medal:

ckerr avatar Dec 23 '22 17:12 ckerr

This does not currently work as-is, in my experience. isPrivate() is undefined (I can change that to getPrivateFlag(), but filtering doesn’t seem to do anything!) I’ve also tried merging current main into the checked-out PR, but also a no-go.

dareiff avatar Oct 25 '23 17:10 dareiff

@dareiff This used to work, but went unmerged for a long time, and now I haven't been able to get it working. I'm hoping someone who knows more about Transmission can figure out what needs to be done to implement this feature.

WillDaSilva avatar Jan 25 '24 14:01 WillDaSilva

Marking as "needs update" if it's no longer building nor working. Sorry, can't help myself on web features.

Coeur avatar Mar 23 '24 15:03 Coeur

Superseded by:

  • https://github.com/transmission/transmission/pull/6737

Thank you @dareiff!

WillDaSilva avatar Mar 25 '24 22:03 WillDaSilva