transgui icon indicating copy to clipboard operation
transgui copied to clipboard

Please add user-defined Labels

Open vladimirvanchytsky opened this issue 7 years ago • 55 comments

Please add user-defined torrent's Labels (such as "Music", "Movies", "SW" etc.) for torrent easy sorting and manipulation.

vladimirvanchytsky avatar Jul 13 '17 13:07 vladimirvanchytsky

zzzzzz I can suggest you to set templates for folders. In the figure, an example of the destination folder for video files.

leonsoft-kras avatar Jul 13 '17 14:07 leonsoft-kras

Thanks, buddy. But there is probably goal misunderstanding. I wrote "for torrent easy sorting and manipulation", meaning already downloaded torrents - so my problem is NOT torrent placement during downloading, but manipulation with already placed torrents. For example, I need to group all downloaded Audiobooks to change data location for all them. Folder view take me no such possibility - it shows only last folder in data location tree, and there is no option to show e.g. first folder after base path.

Upd.: See folder structure - there is far more than one level of hierarchy in e.g. "Audiobooks" branch. In other way it would impossible to find particular movie/audiobook/e-book/music album... capture

vladimirvanchytsky avatar Jul 13 '17 14:07 vladimirvanchytsky

Do you mean just labels as in rutorrent? That would indeed be nice

lordvalium avatar Nov 01 '18 18:11 lordvalium

I started working on this feature and have a dev build ready https://github.com/qu1ck/transgui/releases/tag/label-dev

Imgur

You need server support too, repo here: https://github.com/qu1ck/transmission/tree/labels

qu1ck avatar Jan 20 '19 11:01 qu1ck

Great effort!!!! :+1: A major feature wanted for so long. (more of 7 years)

Pity what the official transmission server doesn't support this... 😢 The transmission developers team refuse to add this feature for years...

For more reading of this: https://github.com/transmission/transmission/issues/79

antekgla avatar Jan 20 '19 16:01 antekgla

@qu1ck It might be better if the existing pull https://github.com/transmission/transmission/pull/137 was utilized. It includes server side download groups https://github.com/transmission/transmission/pull/137/commits/bc8a56f56b9a0ab734d2f26149f17b20e57f43a6 with torrent set and get functions accessible through rpc "downloadGroup". Already well proved for the web client, it is nicely set up for rpc access. It is already integrated for daemon at my fork https://github.com/cfpp2p/transmission . @Belphemur had been doing a nice job keeping it updated for official transmission. There is a little history here: https://trac.transmissionbt.com/ticket/5385 also.

cfpp2p avatar Jan 21 '19 23:01 cfpp2p

Note, qu1ck's work on labels is now in the daemon, merged in transmission/transmission#822. It implements several labels for a torrent.

The code is currently only in the master branch, and changes in the RPC protocol are in the current unversioned spec.

decadent avatar Jun 13 '19 17:06 decadent

So @qu1ck , do you think your branch ready for a pull request?

lvella avatar Dec 21 '19 13:12 lvella

Currently editing the labels is done via simple text field. I'd like to improve it with autocomplete and better UI. But maybe it can be done as a later step.

qu1ck avatar Dec 21 '19 21:12 qu1ck

Currently editing the labels is done via simple text field. I'd like to improve it with autocomplete and better UI. But maybe it can be done as a later step.

Hi qu1ck, I installed your dev build but labels is greyed out for me. Can you recommend a way for me to monitor so I can know when I should update for this feature? thx

gartkb avatar Apr 08 '20 17:04 gartkb

If labels are greyed out that means the server does not support labels. You need to upgrade to dev build of transmission server as well. When I make a pull request it will be attached to this issue so you will get a notification.

qu1ck avatar Apr 08 '20 23:04 qu1ck

My code has been merged. I don't know if I'll have time to improve the UI but it's usable now.

qu1ck avatar Apr 30 '20 08:04 qu1ck

My code has been merged. I don't know if I'll have time to improve the UI but it's usable now.

Does that mean this works with Transmission 3.0?

EDIT: never mind, the code was merged after the last release occured...

PrimozR avatar Jul 26 '20 16:07 PrimozR

Does that mean this works with Transmission 3.0?

Yes it does.

the code was merged after the last release occured

Correct, you need a dev build if you want support for labels in gui.

qu1ck avatar Jul 27 '20 00:07 qu1ck

Correct, you need a dev build if you want support for labels in gui.

Are there any dev builds already prepared so I could test it? I'm not really in a position where I could do my own builds...

PrimozR avatar Jul 27 '20 08:07 PrimozR

I uploaded dev builds for win64 built from current master here https://github.com/qu1ck/transgui/releases/tag/label-dev

qu1ck avatar Jul 28 '20 05:07 qu1ck

I uploaded dev builds for win64 built from current master here https://github.com/qu1ck/transgui/releases/tag/label-dev

THANK YOU! 👍

gartkb avatar Jul 28 '20 16:07 gartkb

This is fantastic, thanks @qu1ck

EDIT: When attempting to clear a label with one or multiple torrents by leaving it empty, I receive an error instead of it clearing the label.

undaunt avatar Aug 11 '20 19:08 undaunt

@undaunt Fixed in #1335 , updated builds here https://github.com/qu1ck/transgui/releases/tag/labels-dev

qu1ck avatar Aug 12 '20 01:08 qu1ck

Awesome, thank you.

undaunt avatar Aug 12 '20 01:08 undaunt

I'm looking forward to using this feature. Been waiting for it for a long time. Any ETA when it's gonna be merged to the master branch and a build containing it will be released?

StentMan avatar Aug 20 '20 08:08 StentMan

This project seems to be heading to abandonware bin, there hasn't been a commit since May. So I wouldn't hold my breath. You can get an unofficial windows build from the link I posted above.

qu1ck avatar Aug 20 '20 08:08 qu1ck

@qu1ck Any chance you are able to put out a MacOS version w/labels? Can I assist in some way if not?

undaunt avatar Oct 04 '20 22:10 undaunt

@undaunt I tried compiling it on my mac but ran into multiple issues. You can give a try yourself, just check out https://github.com/qu1ck/transgui/tree/labels-dev and try to run scripts in setup/macosx. In theory install_deps.sh and create_app_new.sh is all you should need but it didn't work for me on 10.15 and I got stuck on some system dependency not being found.

qu1ck avatar Oct 05 '20 05:10 qu1ck

Actually I managed to get travis to build it for me. I've uploaded mac build to https://github.com/qu1ck/transgui/releases/tag/labels-dev

Tested on 10.15, works fine.

qu1ck avatar Oct 05 '20 06:10 qu1ck

If we're throwing our hats into the ring, is there any chance for the client to use the folder mapping everywhere, so even in the torrent properties display and the like and when adding torrents when you type out the folder where the torrent should be saved?

PrimozR avatar Oct 05 '20 17:10 PrimozR

Not sure what you mean by folder mapping?

qu1ck avatar Oct 05 '20 19:10 qu1ck

Sorry, Path Mapping. In Transmision Remote Gui you have the option of saying 'server:blabla' = 'client:foo' or something along those lines. That means that double clicking on a file with a 'unix/style/Path' is correctly translated to either 'differentUnix/with/a/different/path' or 'WinDrive:\path\to\Folder' and the file is opened, even though the actual Transmission client sees a different location for the file than the client OS.

When browsing for the file location when adding a torrent, the local client folder structure is shown and choosing a certain folder is then translated in the torrent adding window to the server-side-correct path. Is it possible to show a client side relevant path there too? And same goes for the 'Path' column in the torrents view (main view of Transmission Remote GUI), which also shows the server-side path?

I've gotten used to it and my mounts on server-side are relatively simple with Docker (luckily, the paths were very convoluted when I was trying to install and use Transmission in a jail on FreeNAS), so it works OK for now, but this would make it even more seamless, mainly for Windows client users running Transmission servers on Unix servers (I doubt there are any users going the other way).

And this might not be relevant to you, but considering you're adding code to the project, I suppose you might be aware of the underlying architecture and be able to comment on whether this is even possible to be achieved.

PrimozR avatar Oct 05 '20 19:10 PrimozR

Ah, yes, I use path mapping all the time too.

So you are asking that

  1. Path column in torrents table recognize mapped paths and show client's equivalent instead of server's path when mapping is available.
  2. Torrent add dialog recognize mapped paths and allow using local client path when mapping is available.

First is definitely possible and relatively easy. Second is a bit hairy because if both client and server are same platform and paths look the same then it's impossible to recognize that you mean a server path or local mapped path. There probably needs to be an explicit toggle to indicate that you are using local paths and then transgui will validate that the path you chose is mapped correctly.

But either way this is unrelated to labels and I suggest you open a separate issue. Feel free to use my comment for problem description if you agree with it.

qu1ck avatar Oct 05 '20 21:10 qu1ck

Is this at the pull-request stage?

DuncanHills avatar Nov 12 '20 00:11 DuncanHills