uppy icon indicating copy to clipboard operation
uppy copied to clipboard

upload complete event missing files after retry with aws-s3 multipart

Open yellowtailfan opened this issue 1 year ago • 4 comments

Initial checklist

  • [X] I understand this is a bug report and questions should be posted in the Community Forum
  • [X] I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

  1. Uppy current release configured using aws-s3 with shouldUseMultipart set to true
  2. Using our own Lambas as endpoints for AwsS3
  3. Upload multiple large files
  4. One of the large file uploads fails with a 500 error from the fetch inside our createMultipartUpload() (I saw this in the wild, but for this test case I forced the server to randomly return a 500)
  5. I wait for the successful files to complete, no upload complete event is fired
  6. I press the retry button on the failed file in the Dashboard
  7. The retried uploads completes
  8. An upload complete event is emitted
  9. Our upload complete callback only receives the retried file (the initially successful files are not in the list)

If multiple files fail in the same way, then I get an upload complete event for each retried file that successfully completes.

Expected behavior

The upload complete event should include all files that have successfully completed, not just the ones that completed after retrying.

Actual behavior

See above.

yellowtailfan avatar Nov 16 '23 07:11 yellowtailfan