uppy icon indicating copy to clipboard operation
uppy copied to clipboard

Published 20 hours ago • verified publisher icon transloadit

Changed styles of uppy-Webcam-title

Open prabureddy opened this issue 1 year ago • 2 comments

As the h1 style of Uppy docs affects the uppy's library h1.uppy-Webcam-title.

#4439

prabureddy avatar May 18 '23 19:05 prabureddy

Hi! Thanks for the PR. I'd rather handle it differently, probably forgoing the <h1> altogether or using uppy-u-reset class. In most places in Uppy I've purposefully removed semantic typography elements to not conflict with styles on the page.

arturi avatar May 24 '23 11:05 arturi

Diff output files 
No diff

github-actions[bot] avatar Feb 13 '24 19:02 github-actions[bot]

@prabureddy, thanks for the PR!

Agreed with Artur's comment that we could consider removing h1 from uppy to avoid such issues, it is indeed frequent that websites apply global h1/h2/h3 styles.

In uppy.io case, however, I think we were just applying global styles too liberally (non-semantic <section>s were affected too!), and the solution lies in being more specific in our CSS.

Closing this PR as superseded by https://github.com/transloadit/uppy.io/pull/266.

lakesare avatar Jul 16 '24 21:07 lakesare