thumbnail-generator: black border due to incorrect cropping

[lucadalli]

Thumbnails for images from my camera roll have a black border. Seems to be related to EXIF orientation. Below is a comparison showing the thumbnail of the unaltered image (EXIF orientation: rotate CW 90) and the same image after exporting it from Photoshop (EXIF rotation: normal).

broken-thumb.jpg broken-thumb-photoshop.jpg

[lucadalli]

@Murderlon Are you able to use the images attached to reproduce the issue on your end?

We use the images generated from the thumbnail-generator extensively in our application and the mismatch between the aspect ratios of the thumbnail and the original image is causing some nasty bugs.

[Murderlon]

I was able to reproduce this on the dashboard. But looking at it quickly I didn't see what causes this. 95% of the thumbnail logic is browser APIs and the exifr library, not a custom implementation. Would have to look deeper later.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.